Logging improvements#163
Merged
Merged
Conversation
rohitpaulk
force-pushed
the
better-logging
branch
from
99e4874 to
c52c386
Compare
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 98.58% 98.41% -0.18%
==========================================
Files 11 11
Lines 425 441 +16
==========================================
+ Hits 419 434 +15
- Misses 6 7 +1
Continue to review full report at Codecov.
|
f2prateek
approved these changes
May 19, 2018
f2prateek
reviewed
May 23, 2018
| end | ||
|
|
||
| logger.debug("Sending request for #{@batch.length} items") | ||
| res = @request.post(@write_key, @batch) |
Contributor
There was a problem hiding this comment.
hey @rohitpaulk, as a follow up; let's log the result of the HTTP response. I think the status code might be helpful to have here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[analytics-ruby]. Although we could overrideprognamefor this, it isn't really visible in all logging systems, and depends on the formatter used